Improve formatting of ping and uptime commands #1542
Conversation
There was a problem hiding this comment.
Thanks for the contribution.
The change to the uptime command looks fine to me but i'm not sure about the change to the ping command.
The linting is also not passing, if you look at https://github.com/python-discord/sir-lancebot/pull/1542/files you can see the issues, and you can use poetry run task lint locally to lint locally (and poetry run task precommit to set up precommit which will automatically check before you commit).
| @@ -20,7 +21,7 @@ async def ping(self, ctx: commands.Context) -> None: | |||
| embed = Embed( | |||
| title=":ping_pong: Pong!", | |||
| colour=Colours.bright_green, | |||
| description=f"Gateway Latency: {round(self.bot.latency * 1000)}ms", | |||
| description=f"Gateway Latency: `{round(self.bot.latency * 1000)}`ms", | |||
There was a problem hiding this comment.
I think both ways look fine, so I don't really think it's worth changing unless there's a good reason.
There was a problem hiding this comment.
Fair enough. I guess it's personal preference but definitely not a necessary change.
Xithrius
added
area: frontend
wookie184
added
status: waiting for author
|
Are you still interested in working on this @Ken-Miles? |
|
Hi,
I’ve since moved on from contributing to this and in the middle of midterms
at my school. You can feel free to continue work on this.
…On Tue, Apr 8, 2025 at 07:19 wookie184 ***@***.***> wrote:
Are you still interested in working on this @Ken-Miles
<https://github.com/Ken-Miles>?
—
Reply to this email directly, view it on GitHub
<#1542 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALEHRK6NXGF43DIRUQXZH4L2YO5GVAVCNFSM6AAAAAB2WESYF6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOBWGI2TGNJQGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
*wookie184* left a comment (python-discord/sir-lancebot#1542)
<#1542 (comment)>
Are you still interested in working on this @Ken-Miles
<https://github.com/Ken-Miles>?
—
Reply to this email directly, view it on GitHub
<#1542 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALEHRK6NXGF43DIRUQXZH4L2YO5GVAVCNFSM6AAAAAB2WESYF6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOBWGI2TGNJQGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Alrighty, thanks for the quick response! |
Description
I changed the
uptimecommand to use a discord formatted timestamp, rather than formatting the start_time and sending it. This way you can see exactly when the bot started, in your own timezone.In addition, I also added some small formatting to the ping command, so the gateway ping is show in a tiny codeblock
like this.Did you: