-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve frontend performance #1160
Comments
I couldn't reproduce the FOUC behaviour for my devices and browsers I used, even on slower networks. However while working on my dark theme PR I noticed a lot of opportunities to improve performance. The main ones:
Other ideas which probably won't help as much
Other resources: |
Hmm, I can't reproduce this anymore either, maybe because of #1161 or something similar? I agree with you on the other points. I will update this issue for those |
Actually skip that. I've found a reliable way to reproduce it:
There should be a FUOC reproduceable using this method. Can you check? |
Yes, with Firefox using Regular 2G throttling I can reproduce this. However anything above Regular 2G it does not happen. With Chrome-based browsers using network conditions equivalent to that of Firefox's Regular 2G I cannot reproduce FOUC either. I wonder if this is less about our site performance and more about a Firefox bug. It blocks any rendering of the (unstyled) page until it's fully loaded. So before that happens the user sees a blank page. |
Wow, I didn't know that, but it does indeed seem to be a Firefox bug!
That's really annoying. And the fix is kind of strange... I wonder if
it's worth to include.
|
Firstly I believe the overall frontend performance can be improved. Now since this fix targets specifically for firefox users on an incredibly slow connection, it's a matter of comparing the user experience for this audience:
If the overall frontend performance can be improved to such an extent that the waiting time of behavior (2) is acceptable, then I think this fix is definitely worthwhile to include. Especially considering it's a Firefox problem. However right now since we do not have any significant performance improvements work being done, behavior (1) is better IMO so the user can see at least some part of the webpage being loaded first, so they can wait a bit longer for the styles. As compared to (2) right now where the user only sees a blank screen, they might get impatient and close the site. This is just my personal experience when I am the user, though. |
When opening the homepage without the page's styles in cache, the homepage flashes around before the layout is fully loaded. We should load the CSS synchronously or use another solution to prevent this.
To reproduce, refresh the website clearing the cache (on Firefox, CTRL - Shift - R). The slower the connection & the higher the latency, the easier to reproduce
The text was updated successfully, but these errors were encountered: