Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues in https://web.dev/measure #355

Closed
Lvl4Sword opened this issue May 25, 2020 · 2 comments
Closed

Fix issues in https://web.dev/measure #355

Lvl4Sword opened this issue May 25, 2020 · 2 comments
Labels
level: 1 - intermediate priority: 2 - normal Normal Priority status: planning Discussing details type: feature New feature or request

Comments

@Lvl4Sword
Copy link

Lvl4Sword commented May 25, 2020

According to https://lighthouse-dot-webdotdevsite.appspot.com//lh/html?url=https%3A%2F%2Fpythondiscord.com ( through https://web.dev/measure ), the Python Discord site currently scores 74/100 in Performance, 86/100 in Accessibility, 100/100 in Best Practices, and 91/100 in SEO.
These seem like some relatively easy things to implement for the speed ( and other ) bonuses they offer.

@lemonsaurus
Copy link
Member

Here are actual actionable points:

Don't load unused Bulma Extensions

Currently, we're not defining the extensions key in our BULMA_SETTINGS config dict. This means that all Bulma extensions are being loaded, which is stupid because we're not using any of them afaik.

To solve this, just add extensions=[] to BULMA_SETTINGS.

Off-site asset loading has bad caching policies

We're loading a few assets from off-site - the Django logo from djangoproject.com, and some code jam banner from the githubusercontent CDN. These both have bad caching policies as a result. Fetch these images, add them to the site, and update the references to the local ones instead.

Resource-blocking assets

We don't preload CSS, and we don't defer loading of JS. This should be fixed.

This fix mostly needs to happen in django-simple-bulma, so see lemonsaurus/django-simple-bulma#45 - but we may be importing other stuff (local css, maybe fontawesome?) that could use this treatment as well.

Minification of JS and CSS

We don't minify JS and CSS.

Same story here - this mostly should be addressed in django-simple-bulma (lemonsaurus/django-simple-bulma#44) but may need to be addressed for a few local files as well.

Images should be the right size

There's probably some images resized by width and height parameters or css - this is wasteful compared to just serving them at the right size. So, just resize those assets and remove the resizing.

@MarkKoz
Copy link
Member

MarkKoz commented Jul 16, 2020

@Lvl4Sword Are you still working on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level: 1 - intermediate priority: 2 - normal Normal Priority status: planning Discussing details type: feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants