Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing margin-left property from base.css to fix the overflow #1121

Merged
merged 4 commits into from
Oct 23, 2023
Merged

Conversation

sarzz2
Copy link
Contributor

@sarzz2 sarzz2 commented Oct 5, 2023

Summary

Fixes #1015 Issue

Description of changes

removing the margin-left property from base.css to fix the overflow caused by the discord button logo on the top right of the page when screen size is lowered.

I confirm I have:

@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for pydis-static ready!

Name Link
🔨 Latest commit eabecdd
🔍 Latest deploy log https://app.netlify.com/sites/pydis-static/deploys/65369e9ff209550008cfff86
😎 Deploy Preview https://deploy-preview-1121--pydis-static.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Oct 5, 2023

Coverage Status

coverage: 100.0%. remained the same when pulling eabecdd on sarzz2:main into fe0c8a7 on python-discord:main.

Copy link
Member

@jchristgit jchristgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

@kosayoda kosayoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the preview deployment, and unfortunately the issue is not fixed. The issue is still reproducible on:

  • Stock chromium
image
  • Firefox, with persistent scrollbars General > Browsing > Always show scrollbars:
image

Given how finnicky the issue is, I'm inclined to suggest the removal of both padding-left and padding-right directly, which fixes the issue in all my test cases. It is a visual change, but I don't think it hurts the look:

image image

@sarzz2
Copy link
Contributor Author

sarzz2 commented Oct 8, 2023

Removing both padding left and right makes the button look a little squeezed, we can just remove padding-right:2.5rem to fix the issue with persistent scrollbars on firefox.

Note: Chrome doesn't have this issue since the persistent scrollbar option is not available in settings afaik.

@kosayoda
Copy link
Member

kosayoda commented Oct 8, 2023

...we can just remove padding-right:2.5rem to fix the issue with persistent scrollbars on firefox.

Sounds good to me!

@sarzz2
Copy link
Contributor Author

sarzz2 commented Oct 8, 2023

Merged the main branch and updated the file to remove padding.

@sarzz2
Copy link
Contributor Author

sarzz2 commented Oct 22, 2023

@kosayoda could you review now and close PR if all is good?

@kosayoda kosayoda enabled auto-merge October 23, 2023 16:26
@kosayoda kosayoda merged commit ad89dbe into python-discord:main Oct 23, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discord Button Shifts Off-Page at 1024-1040px Screen Width
4 participants