-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removing margin-left property from base.css to fix the overflow #1121
Conversation
…d by discord button on top right
✅ Deploy Preview for pydis-static ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the preview deployment, and unfortunately the issue is not fixed. The issue is still reproducible on:
- Stock chromium
- Firefox, with persistent scrollbars
General > Browsing > Always show scrollbars
:
Given how finnicky the issue is, I'm inclined to suggest the removal of both padding-left
and padding-right
directly, which fixes the issue in all my test cases. It is a visual change, but I don't think it hurts the look:
Removing both padding left and right makes the button look a little squeezed, we can just remove Note: Chrome doesn't have this issue since the persistent scrollbar option is not available in settings afaik. |
Sounds good to me! |
Merged the main branch and updated the file to remove padding. |
@kosayoda could you review now and close PR if all is good? |
Summary
Fixes #1015 Issue
Description of changes
removing the margin-left property from base.css to fix the overflow caused by the discord button logo on the top right of the page when screen size is lowered.
I confirm I have: