-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed truncated dropdown menu #1138
Conversation
✅ Deploy Preview for pydis-static ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This was bothering me for a long time.
One problem though, this doesn't fix it on mobile:
Maybe it's out of scope, I could fix this case in another PR.
However, here's my idea:
We can add two lines to the max width media query (in the same file), so the dropdown menu can then be fixed on the right edge:
On line 12, something like this:
.dropdown-menu {
left: unset;
right: 0;
}
What do you think?
works fine @hedyhli committed the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All seems good to me, thanks
Co-authored-by: wookie184 <wookie1840@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works beautifully 👍
fixes #1037
Summary
In the "Sub-Articles" section of the "Contributing" page, when the dropdown menu is expanded, some section names are cut off at the right edge of the page making user scroll horizontally.
Description of changes
removed nowrap property and adjusted CSS of the subarticle to make it fit on the page
I confirm I have: