Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify frozen fields logic into serializer mixin #1169

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Unify frozen fields logic into serializer mixin #1169

merged 1 commit into from
Dec 11, 2023

Conversation

jchristgit
Copy link
Member

Additionally, implement frozen fields on the offensive message serializer.

@jchristgit
Unify frozen fields logic into serializer mixin
c20f411 
Additionally, implement frozen fields on the offensive message
serializer.
@jchristgit jchristgit added area: backend Related to internal functionality and utilities language: python Involves Python code priority: 2 - normal Normal Priority level: 1 - intermediate type: enhancement Changes or improvements to existing features labels Dec 11, 2023
@jchristgit jchristgit requested a review from shtlrs December 11, 2023 15:52
@jchristgit jchristgit requested a review from MarkKoz as a code owner December 11, 2023 15:52
@netlify Netlify
Copy link

netlify bot commented Dec 11, 2023 •
edited
Loading

✅ Deploy Preview for pydis-static ready!

Name Link
🔨 Latest commit c20f411
🔍 Latest deploy log https://app.netlify.com/sites/pydis-static/deploys/6577304aabf5cc00085fcfa2
😎 Deploy Preview https://deploy-preview-1169--pydis-static.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling c20f411 on frozen-fields-unify
into f641746 on main.

@ChrisLovering ChrisLovering merged commit e8f8161 into main Dec 11, 2023
11 of 12 checks passed
@ChrisLovering ChrisLovering deleted the frozen-fields-unify branch December 11, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisLovering ChrisLovering ChrisLovering approved these changes

@shtlrs shtlrs Awaiting requested review from shtlrs

@MarkKoz MarkKoz Awaiting requested review from MarkKoz MarkKoz is a code owner

Assignees
No one assigned
Labels
area: backend Related to internal functionality and utilities language: python Involves Python code level: 1 - intermediate priority: 2 - normal Normal Priority type: enhancement Changes or improvements to existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jchristgit @coveralls @ChrisLovering