Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate mailing lists to their own API endpoints #1174

Merged
merged 2 commits into from
Feb 3, 2024
Merged

Conversation

jchristgit
Copy link
Member

Add a new model for the bot to store its mailing list state in, as opposed to the current JSON blob in the BotSetting table. Migrate the existing settings from the BotSetting table into the new model.

@jchristgit jchristgit added area: backend Related to internal functionality and utilities area: API Related to or causes API changes language: python Involves Python code type: feature New feature or request priority: 2 - normal Normal Priority level: 1 - intermediate labels Dec 13, 2023
@jchristgit jchristgit requested a review from Den4200 as a code owner December 13, 2023 08:11
Copy link

netlify bot commented Dec 13, 2023

Deploy Preview for pydis-static ready!

Name Link
🔨 Latest commit ad2410e
🔍 Latest deploy log https://app.netlify.com/sites/pydis-static/deploys/65bdfe67962292000768ac53
😎 Deploy Preview https://deploy-preview-1174--pydis-static.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Dec 13, 2023

Coverage Status

coverage: 100.0%. remained the same
when pulling ad2410e on mailing-list-model
into e7b2b09 on main.

Copy link
Member

@shtlrs shtlrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes !
This is just a code review for the timebeing, will test in a later instance.

@jchristgit jchristgit requested a review from shtlrs December 14, 2023 10:14
@jchristgit jchristgit force-pushed the mailing-list-model branch 2 times, most recently from 2d2f50b to a442d53 Compare December 14, 2023 13:29
@shtlrs shtlrs added the review: do not merge The PR can be reviewed but cannot be merged now label Dec 14, 2023
Copy link
Member

@shtlrs shtlrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks !
I've marked this as do not merge untiil the bot pr is ready.

Add a new model for the bot to store its mailing list state in, as
opposed to the current JSON blob in the BotSetting table. Migrate the
existing settings from the BotSetting table into the new model.
Copy link
Member

@shtlrs shtlrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On The House

@Xithrius Xithrius removed the review: do not merge The PR can be reviewed but cannot be merged now label Feb 3, 2024
@Xithrius Xithrius enabled auto-merge February 3, 2024 08:50
@Xithrius Xithrius merged commit c55050e into main Feb 3, 2024
10 of 11 checks passed
@Xithrius Xithrius deleted the mailing-list-model branch February 3, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: API Related to or causes API changes area: backend Related to internal functionality and utilities language: python Involves Python code level: 1 - intermediate priority: 2 - normal Normal Priority type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants