-
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate mailing lists to their own API endpoints #1174
Conversation
✅ Deploy Preview for pydis-static ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
a2f0e23
to
a650c30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great changes !
This is just a code review for the timebeing, will test in a later instance.
pydis_site/apps/api/migrations/0096_mailinglistseenitem_unique_list_and_hash.py
Outdated
Show resolved
Hide resolved
a650c30
to
857cee7
Compare
2d2f50b
to
a442d53
Compare
a442d53
to
9e5b864
Compare
pydis_site/apps/api/migrations/0094_migrate_mailing_listdata.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great, thanks !
I've marked this as do not merge untiil the bot pr is ready.
9e5b864
to
119fd5b
Compare
Add a new model for the bot to store its mailing list state in, as opposed to the current JSON blob in the BotSetting table. Migrate the existing settings from the BotSetting table into the new model.
119fd5b
to
a908b9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On The House
Add a new model for the bot to store its mailing list state in, as opposed to the current JSON blob in the BotSetting table. Migrate the existing settings from the BotSetting table into the new model.