Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preload nomination entries in nomination viewset #1187

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Preload nomination entries in nomination viewset #1187

merged 1 commit into from
Dec 15, 2023

Conversation

jchristgit
Copy link
Member

@jchristgit jchristgit added area: backend Related to internal functionality and utilities language: python Involves Python code priority: 2 - normal Normal Priority level: 1 - intermediate type: enhancement Changes or improvements to existing features labels Dec 15, 2023
@netlify Netlify
Copy link

netlify bot commented Dec 15, 2023 •
edited
Loading

✅ Deploy Preview for pydis-static ready!

Name Link
🔨 Latest commit f04fbeb
🔍 Latest deploy log https://app.netlify.com/sites/pydis-static/deploys/657c7b74f5187a0009b1fc4a
😎 Deploy Preview https://deploy-preview-1187--pydis-static.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling f04fbeb on nplusone-nomination-entries
into 14e9005 on main.

shtlrs
shtlrs approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@shtlrs shtlrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terrific!

@shtlrs shtlrs merged commit 9e4d037 into main Dec 15, 2023
12 checks passed
@shtlrs shtlrs deleted the nplusone-nomination-entries branch December 15, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shtlrs shtlrs shtlrs approved these changes

@ChrisLovering ChrisLovering ChrisLovering approved these changes

Assignees
No one assigned
Labels
area: backend Related to internal functionality and utilities language: python Involves Python code level: 1 - intermediate priority: 2 - normal Normal Priority type: enhancement Changes or improvements to existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jchristgit @coveralls @ChrisLovering @shtlrs