Off-load pyinstaller config to its hook #328
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Strong change |
|
https://github.com/pyinstaller/pyinstaller/releases/tag/v4.0 has been released now - update Eel for PyInstaller v4 and merge this. |
samuelhwilliams
force-pushed
the
use-pyinstaller-hook
branch
3 times, most recently
from
0630fca
to
3f8d06c
Compare
PyInstaller now has a custom hook for Eel (pyinstaller/pyinstaller-hooks-contrib#6) that tells it how to collect eel.js and our hidden imports (bottle-websocket), so we don't need our own code to enable this. We can also define a 'distribution' extra for Eel to additionally install PyInstaller for the user.
samuelhwilliams
force-pushed
the
use-pyinstaller-hook
branch
from
3f8d06c
to
8b1d100
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyInstaller now has a custom hook for Eel
(pyinstaller/pyinstaller-hooks-contrib#6) that
tells it how to collect eel.js and our hidden imports
(bottle-websocket), so we don't need our own code to enable this.
We can also define a 'distribution' extra for Eel to additionally
install PyInstaller for the user.
NOTE: We need to wait for a release of PyInstaller that includes the new hook.