Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(merge): parse arguments as query_data #1121

Merged
merged 1 commit into from
Jun 19, 2020
Merged

fix(merge): parse arguments as query_data #1121

merged 1 commit into from
Jun 19, 2020

Conversation

ferhat-aram
Copy link

Refer to #1120

Merge request requests aren't working, as the request parameters should_remove_source_branch and remove_source_branch are parsed as post_data, when they should be send as query_string, as described in the official GitLab API documentation itself GitLab API Accept Merge

@max-wittig
Copy link
Member

Thanks for the MR!

@max-wittig max-wittig merged commit 1d82310 into python-gitlab:master Jun 19, 2020
@ferhat-aram ferhat-aram deleted the fix/bad-merge-request-arg-parsing branch June 19, 2020 14:09
@ferhat-aram ferhat-aram mentioned this pull request Jun 19, 2020
Closed
@jaserieger jaserieger mentioned this pull request May 13, 2021
Closed
@JohnVillalovos JohnVillalovos mentioned this pull request May 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ferhat-aram @max-wittig