-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a few more BFS-based algorithms #51
Conversation
- Components - `is_connected` - `is_weakly_connected` - `node_connected_component` - Shortest Paths - `all_pairs_shortest_path_length` - `negative_edge_cycle` - `single_source_shortest_path_length` - `single_target_shortest_path_length` - Traversal - `bfs_layers` - `descendants_at_distance`
I'm also not sure if these are the best algorithms for connected component-related functions. Connected components are an important class of algorithms that we should add soon (for example, we have an implementation of FastSV in a Jupyter notebook that we can port over), so perhaps we'll revisit these algorithms then. |
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
==========================================
+ Coverage 69.16% 71.62% +2.46%
==========================================
Files 77 89 +12
Lines 3152 3461 +309
Branches 602 642 +40
==========================================
+ Hits 2180 2479 +299
+ Misses 786 783 -3
- Partials 186 199 +13
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Merging so we can do a release before PyConUS. May be able to benchmark and shakedown some algorithms later, but they're probably good enough. |
BFS is a workhorse! There are still many BFS-based algorithms still to do.
My main TODO is to benchmark these to give them a proper shakedown. I like to shake down most algorithms we add. Also, I wonder whether we should use
A.T
orAT
in a couple places. I also wonder if we can come up with a heuristic to detect negative cycles.It may be nice to know whether directed graphs are structurally symmetric. If we knew this, we could improve
is_weakly_connected
and other algorithms.Also, there may be a couple NetworkX bugs to fix or behaviors to match.
Implemented:
is_connected
is_weakly_connected
node_connected_component
all_pairs_shortest_path_length
negative_edge_cycle
single_source_shortest_path_length
single_target_shortest_path_length
bfs_layers
descendants_at_distance