-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement google_matrix
and binary operators
#62
Conversation
@jim22k, |
Other than my comment above, this all looks good to me. |
Thanks for reviewing! Thoughts on the failing test? |
I think the line: The point of that test is to check that Can you make that change in NetworkX and see if the tests pass? If so, please add that change to your NetworkX PR. Thanks! |
This doesn't work, b/c we convert networkx graphs (we always call e.g. |
Oops. Try this instead: # Only test if not performing auto convert testing of backend implementations
if os.environ.get("NETWORKX_GRAPH_CONVERT", None) is None: The goal is to only test this if we aren't doing auto convert testing. |
This change was suggested here: python-graphblas/graphblas-algorithms#62 (comment)
Merging. The test failure is understood--we are waiting on NetworkX PR to be merged. |
* Handle weights as `distance=` in testing dispatch * fix `test_intersection` This change was suggested here: python-graphblas/graphblas-algorithms#62 (comment)
* Handle weights as `distance=` in testing dispatch * fix `test_intersection` This change was suggested here: python-graphblas/graphblas-algorithms#62 (comment)
* Handle weights as `distance=` in testing dispatch * fix `test_intersection` This change was suggested here: python-graphblas/graphblas-algorithms#62 (comment)
* Handle weights as `distance=` in testing dispatch * fix `test_intersection` This change was suggested here: python-graphblas/graphblas-algorithms#62 (comment)
These aren't super-optimized or super-clean, but are hopefully "good enough" for a while.