Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using blocklist #1207

Closed
annevk opened this issue Jan 3, 2020 · 2 comments · Fixed by #1208
Closed

Consider using blocklist #1207

annevk opened this issue Jan 3, 2020 · 2 comments · Fixed by #1208

Comments

@annevk
Copy link
Contributor

annevk commented Jan 3, 2020

When grepping another codebase I got

tools/third_party/h2/examples/fragments/client_https_setup_fragment.py:    # blacklist defined in this section allows only the AES GCM and ChaCha20
tools/third_party/h2/examples/fragments/server_https_setup_fragment.py:    # blacklist defined in this section allows only the AES GCM and ChaCha20

It'd be nice to replace that with blocklist or equivalent.
@annevk annevk mentioned this issue Jan 3, 2020
Merged
@pgjones
Copy link
Member

pgjones commented Jan 3, 2020

Could you open a PR?

@annevk annevk mentioned this issue Jan 3, 2020
Merged
@annevk
Copy link
Contributor Author

annevk commented Jan 3, 2020

Done, though CI had a hiccup. Also filed tox-dev/tox#1491 on an upstream problem.

pgjones pushed a commit that referenced this issue Jan 3, 2020
@annevk @pgjones
Use blocklist rather than blacklist
fd0db1f 
Closes #1207.
@annevk annevk mentioned this issue Jul 23, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use blocklist rather than blacklist
2 participants
@pgjones @annevk