Skip to content

Simplify the hex formatting in _url.py #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2017
Merged

Simplify the hex formatting in _url.py #29

merged 1 commit into from
Jul 3, 2017

Conversation

alexwlchan
Copy link
Contributor

Following up on my suggestion in #23. Makes this line a little more readable, and consistent with line 177:

ret[c] = ret[v] = '%{0:02X}'.format(i)

Informal testing with timeit is inconclusive, suggesting they’re about the same time.

@codecov-io
Copy link

codecov-io commented Jul 3, 2017

Codecov Report

Merging #29 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #29   +/-   ##
=======================================
  Coverage   96.78%   96.78%           
=======================================
  Files           6        6           
  Lines        1026     1026           
  Branches      123      123           
=======================================
  Hits          993      993           
  Misses         19       19           
  Partials       14       14
Impacted Files Coverage Δ
hyperlink/_url.py 93.69% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d30724...ab5e607. Read the comment docs.

Copy link
Member

@mahmoud mahmoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mahmoud mahmoud merged commit 7f52c6d into master Jul 3, 2017
@alexwlchan alexwlchan deleted the alex/hexord branch July 3, 2017 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants