Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance degradation from 2023.7.1 to 2023.11.1 #31

Closed
rcarpa opened this issue Nov 30, 2023 · 3 comments
Closed

performance degradation from 2023.7.1 to 2023.11.1 #31

rcarpa opened this issue Nov 30, 2023 · 3 comments

Comments

@rcarpa
Copy link

rcarpa commented Nov 30, 2023

Hi team. We just upgraded from 2023.7.1 to 2023.11.1 and our CPU utilization increased by almost an order of magnitude with the same workload. We use this package indirectly via jsonschema == 4.18.6.

Are you aware of what could cause such an issue. If yes, is there an easy workaround?

The affected line of code is here. In case it can help you with the investigation.

https://github.com/rucio/rucio/blob/0290623118d0890e799b848d72f2c1a3b18b2b04/lib/rucio/core/trace.py#L356C13-L356C21

@Julian
Copy link
Member

Julian commented Nov 30, 2023

There are essentially no functional changes to this library whatsoever between those two versions, so something else is happening. I'd need to see a minimal reproducer -- you've already profiled your code and seen it's this library specifically that's involved?

@rcarpa
Copy link
Author

rcarpa commented Nov 30, 2023

This library is not a direct dependency of our code. It comes as a dependency of jsonschema (which is pinned in our dependencies to jsonschema~=4.18.4).

https://github.com/python-jsonschema/jsonschema/blob/b307f310f86b191dd266bfba1de0eea61f0ee194/pyproject.toml#L38

I can trigger the high CPU usage by doing

pip install jsonschema-specifications==2023.11.1

and bring things back to normal with

pip install jsonschema-specifications==2023.7.1 

Nothing else changes in the meantime (no other sub-dependencies get re-installed by these commands)

@Julian
Copy link
Member

Julian commented Nov 30, 2023

I see the issue, should be fixed in a moment with a new release. Thanks for the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants