Ensure proper sorting of list in error message

Fixes problem where error message was con consistent between runs.
python-jsonschema · May 5, 2022 · eef7417 · eef7417
1 parent 7949bf6
commit eef7417
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/jsonschema/_utils.py b/jsonschema/_utils.py
@@ -113,7 +113,7 @@ def extras_msg(extras):
         verb = "was"
     else:
         verb = "were"
-    return ", ".join(repr(extra) for extra in extras), verb
+    return ", ".join(repr(extra) for extra in sorted(extras)), verb
 
 
 def ensure_list(thing):

diff --git a/jsonschema/tests/test_validators.py b/jsonschema/tests/test_validators.py
@@ -594,7 +594,7 @@ def test_unevaluated_items(self):
         message = self.message_for(instance=["foo", "bar"], schema=schema)
         self.assertIn(
             message,
-            "Unevaluated items are not allowed ('foo', 'bar' were unexpected)",
+            "Unevaluated items are not allowed ('bar', 'foo' were unexpected)",
         )
 
     def test_unevaluated_properties(self):
@@ -609,7 +609,7 @@ def test_unevaluated_properties(self):
         self.assertEqual(
             message,
             "Unevaluated properties are not allowed "
-            "('foo', 'bar' were unexpected)",
+            "('bar', 'foo' were unexpected)",
         )