Skip to content

Clarify "pyls" vs "pylsp" #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stefaneidelloth opened this issue Mar 16, 2022 · 1 comment
Closed

Clarify "pyls" vs "pylsp" #173

stefaneidelloth opened this issue Mar 16, 2022 · 1 comment

Comments

@stefaneidelloth
Copy link

stefaneidelloth commented Mar 16, 2022

I would like to enable pylint checks for jupyterlab-lsp and tried to configure the servers in the Advanced Settings Editor as
described in:

https://github.com/jupyter-lsp/jupyterlab-lsp#configuring-the-servers

While jupyterlab-lsp uses "pyls" as name, python-lsp-server seams to use "pylsp".

=> What is the right name to use? Are pyls and pylsp different things or has pyls been renamed to pylsp?

Related: #171

I even tried to include both settings but following config does not enable pylint:

{  
    "language_servers": {
        "pyright": {
            "serverSettings": {
                "python.analysis.useLibraryCodeForTypes": true
            }
        },
        "pyls": {
            "serverSettings": {
                "pyls": {
                    "plugins": {
                        "pydocstyle": {
                          "enabled": true
                        },
                        "pyflakes": {
                          "enabled": true
                        },
                        "flake8": {
                          "enabled": true
                        },
                        "pylint": {
                          "enabled": true
                        }
                    }
                }
            }
        },
        "pylsp": {
            "serverSettings": {
                "pylsp": {
                    "plugins": {
                        "pydocstyle": {
                          "enabled": true
                        },
                        "pyflakes": {
                          "enabled": true
                        },
                        "flake8": {
                          "enabled": true
                        },
                        "pylint": {
                          "enabled": true
                        }
                    }
                }
            }
        }
    }
    
}
@stefaneidelloth
Copy link
Author

https://github.com/jupyter-lsp/jupyterlab-lsp#configuring-the-servers

says:

Note: for the new (currently recommended) python-lsp-server replace pyls occurrences with pylsp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant