Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Different versions of autopep can be installed as optional dependencies #513

Closed
doolio opened this issue Jan 19, 2024 · 0 comments · Fixed by #514
Closed

Different versions of autopep can be installed as optional dependencies #513

doolio opened this issue Jan 19, 2024 · 0 comments · Fixed by #514
Milestone
v1.10.0

Comments

@doolio
Copy link
Contributor

doolio commented Jan 19, 2024

If one selects python-lsp-server[all] optional dependencies they will get the following:

python-lsp-server/pyproject.toml

Lines 28 to 30 in 762853c

[project.optional-dependencies]
all = [
"autopep8>=2.0.4,<2.1.0",

However, if they select python-lsp-server[autopep8] they will get the following:

python-lsp-server/pyproject.toml

Line 41 in 762853c

autopep8 = ["autopep8>=1.6.0,<2.1.0"]

doolio added a commit to doolio/python-lsp-server that referenced this issue Jan 19, 2024
@doolio
Fix optional dependency version
eb717de 
This ensures the same version of autopep8 is installed whether the user
passes "python-lsp-server[all]" or "python-lsp-server[autopep8]" to pip.

Resolves: python-lsp#513
@doolio doolio mentioned this issue Jan 19, 2024
Merged
@ccordoba12 ccordoba12 added this to the v1.10.0 milestone Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.10.0
Development

Successfully merging a pull request may close this issue.

Fix optional dependency version for autopep8 doolio/python-lsp-server
2 participants
@ccordoba12 @doolio