Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use sys.executable in flake8 plugin to make tests pass on systems that don't provide a python link #111

Merged
merged 2 commits into from
Nov 13, 2021
Merged

Use sys.executable in flake8 plugin to make tests pass on systems that don't provide a python link #111

merged 2 commits into from
Nov 13, 2021

Conversation

0-wiz-0
Copy link
Contributor

@0-wiz-0 0-wiz-0 commented Nov 5, 2021 •
edited by ccordoba12
Loading

Part of #109.

@0-wiz-0 0-wiz-0 mentioned this pull request Nov 5, 2021
Open
@ccordoba12 ccordoba12 changed the title Use sys.executable to make tests pass on systems that don't provide "… Use sys.executable to make tests pass on systems that don't provide a python link Nov 5, 2021
ccordoba12
ccordoba12 reviewed Nov 13, 2021
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0-wiz-0, thanks for your help with this! Please fix the error reported by Pylint so I can merge this one.

@0-wiz-0
Copy link
Contributor Author

0-wiz-0 commented Nov 13, 2021

I've just pushed a change that fixes the pylint warning when I run pylint locally. Thanks for the review!

@ccordoba12 ccordoba12 added this to the v1.3.0 milestone Nov 13, 2021
ccordoba12
ccordoba12 approved these changes Nov 13, 2021
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thanks @0-wiz-0!

@ccordoba12 ccordoba12 changed the title Use sys.executable to make tests pass on systems that don't provide a python link Use sys.executable in flake8 plugin to make tests pass on systems that don't provide a python link Nov 13, 2021
@ccordoba12 ccordoba12 merged commit 1b649df into python-lsp:develop Nov 13, 2021
@bnavigator bnavigator mentioned this pull request Jan 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@0-wiz-0 @ccordoba12