Fix Jedi type map (use types offered by modern Jedi) #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krassowski
force-pushed
the
fix-jedi-types-map
branch
from
d77dd34 to
5002197
Compare
ccordoba12
reviewed
Apr 25, 2021
There was a problem hiding this comment.
Thanks for your help @krassowski! I left a minor comment, otherwise looks good to me.
krassowski
force-pushed
the
fix-jedi-types-map
branch
from
7efc8d3 to
e81594c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type map used by Jedi completion is severely outdated (includes types that are never returned by Jedi, and is missing types which are). This PR updates the types list (including future-proof namespace which is going to be introduced in next release) and adds a test to verify that these types actually are returned by Jedi for objects of such types (and properly mapped to LSP types).