Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match rope_completions setting documentation with reality #210

Merged
merged 1 commit into from
May 9, 2022
Merged

Match rope_completions setting documentation with reality #210

merged 1 commit into from
May 9, 2022

Conversation

rchl
Copy link
Contributor

@rchl rchl commented May 7, 2022

Fixes #209

@ccordoba12 ccordoba12 added this to the v1.5.0 milestone May 9, 2022
ccordoba12
ccordoba12 approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @rchl!

@ccordoba12 ccordoba12 merged commit 0563435 into python-lsp:develop May 9, 2022
@rchl rchl deleted the fix/rope-completions branch May 10, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.

Rope completions enabled or disabled by default?
2 participants
@rchl @ccordoba12