Ensure proper document match to avoid empty outline (Symbols) #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... also if module_path is not a Path
|
As a sidenote, this has only become relevant since the change in commit 8fda905, since before that this was handled by |
ccordoba12
changed the title
ccordoba12
approved these changes
Dec 28, 2022
There was a problem hiding this comment.
Thanks @mnauw! I'm going to merge this because it looks good to me and we need it for 1.7.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... also if module_path is not a Path
Mileage may vary, but at least on my setup some sprinkled logging shows that
d.module_pathis not aPath(but rather string), so the comparison turnsFalse, and so the result is an empty outline. Wrapping it inPathshould make it work whether or not it is aPath.