-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for pyflakes 3.1 and pycodestyle 2.11 #415
Conversation
Forgot to mention - the lower bound for pyflakes is bumped to 3.1.0 as flake8 6.1.0 already requires that version, as described in flake8 release notes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yan12125 for your help with this! We also need to bump our supported pycodestyle
version, according to:
Good point, thanks!
(https://github.com/python-lsp/python-lsp-server/actions/runs/5839448515/job/15843654307) New flake8 requires Python 3.8 [1]. Is it better to drop Python 3.7 from python-lsp-server or install older dependencies for older Python? [1] https://flake8.pycqa.org/en/latest/release-notes/6.0.0.html |
Right. I already did that in pull request #417. So, please rebase your pull request or merge with the latest master to get the changes. Then, your pull request should pass. |
`ContinueInFinally` is dropped in pyflakes 3.1 [1]. flake8 is bumped to a version that supports pyflakes 3.1 [2]. pyflakes is also bumped to have the same version range as flake8 [2] (thanks ccordoba12 for the notice). Closes #412 [1] PyCQA/pyflakes#752 [2] https://flake8.pycqa.org/en/latest/release-notes/6.1.0.html Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
Thank you! Rebased and squashed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yan12125 for your help with this!
ContinueInFinally
is dropped in pyflakes 3.1 [1].flake8 is bumped to a version that supports pyflakes 3.1 [2].
Closes #412
[1] PyCQA/pyflakes#752
[2] https://flake8.pycqa.org/en/latest/release-notes/6.1.0.html