-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format the whole repo with Black #419
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkrabel-db
force-pushed
the
392-black-format
branch
from
August 15, 2023 10:49
cea9f52
to
09c9b65
Compare
ccordoba12
reviewed
Aug 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tkrabel-db for your help with this!
ccordoba12
changed the title
black format the whole Repo
Format the whole repo with Black
Aug 15, 2023
ccordoba12
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now, thanks @tkrabel-db!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed in that PR?
Fixes #392, i.e. this PR auto formats the whole repo using
black
to see the diff.black is arguably the most popular formatter out there.
What needs to be changed further?
Some black re-formattings violate
pylint
andpycodestyle
, e.g.pycodestyle
pylint pylsp
My suggestion:
black
takes care of code styling, so we can removepycodestyle
altogether.pylint
goes deeper, as it also e.g. cares about import order, so I suggest the user needs to fix these manually