Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass argument extendIgnore to flake8 #469

Merged
merged 1 commit into from
Oct 21, 2023
Merged

Conversation

UnkwUsr
Copy link
Contributor

@UnkwUsr UnkwUsr commented Oct 20, 2023

As black formatter documentation recommends adding extend-ignore="E203" to flake8, it would be nice if we could be able to do this from lsp server options.

@ccordoba12 ccordoba12 changed the title feat(flake8): pass argument extendIgnore Pass argument extendIgnore to flake8 Oct 20, 2023
@ccordoba12 ccordoba12 added this to the v1.9.0 milestone Oct 20, 2023
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @UnkwUsr for your contribution! Since this is a new option to configure the server, you need to also add it to

https://github.com/python-lsp/python-lsp-server/blob/develop/pylsp/config/schema.json

and then run the last command of this section in our Readme:

https://github.com/python-lsp/python-lsp-server#development

That will regenerate our markdown configuration file:

https://github.com/python-lsp/python-lsp-server/blob/develop/CONFIGURATION.md

with the option you want to add here.

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @UnkwUsr!

@ccordoba12 ccordoba12 added the enhancement New feature or request label Oct 21, 2023
@ccordoba12 ccordoba12 merged commit 728929c into python-lsp:develop Oct 21, 2023
10 checks passed
staticf0x pushed a commit to staticf0x/python-lsp-server that referenced this pull request Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants