Introduce isort to check import order #501
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@ccordoba12 this addresses #499 (comment) |
Contributor
Author
|
Actually, using ruff is even better. #502 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just me getting as many file changes into this project as possible for fame and glory 🎉
Fun aside, a couple of times already I had to address some import order things, and TBH, I am just not good at spotting that. That's why I think it's helpful using
isort. Since we're usingblackas well, it's recommended to use the black profile for isort.This PR adds isort checks to the static code analysis pipeline and runs
isort --profile blackon the repo once.