Drop ujson and switch to orjson #579
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
reviewed
Jul 30, 2024
There was a problem hiding this comment.
Thanks for your help with this @rumpelsepp!
Besides these changes, you also need to replace ujson in python-lsp-jsonrpc for the switch to be complete.
rumpelsepp
force-pushed
the
orjson
branch
3 times, most recently
from
4a01423 to
ce08bbc
Compare
rumpelsepp
added a commit
to rumpelsepp/python-lsp-jsonrpc
that referenced
this pull request
Jul 30, 2024
Implemented as requested in this comment: python-lsp/python-lsp-server#579 (review)
rumpelsepp
added a commit
to rumpelsepp/python-lsp-jsonrpc
that referenced
this pull request
Jul 30, 2024
Implemented as requested in this comment: python-lsp/python-lsp-server#579 (review)
|
I realized there is a typing issue with this. |
valrus
pushed a commit
to valrus/python-lsp-jsonrpc
that referenced
this pull request
Aug 17, 2024
Implemented as requested in this comment: python-lsp/python-lsp-server#579 (review)
|
Closing in favor of #591. Thanks for your work on this @rumpelsepp! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented as requested in this comment:
#508 (comment)