Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not call get_signatures() if snippets are disabled #58

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

krassowski
Copy link
Contributor

This is a key change that should have been included in #26 but was left out by omission when porting the changes from my fork.

This is a key change that should have been included in #26 but was left out by omission when porting the changes from my fork.
@krassowski krassowski added this to the v1.2.0 milestone Jul 14, 2021
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @krassowski!

@ccordoba12 ccordoba12 changed the title Performance: do not call get_signatures() if snippets are disabled Do not call get_signatures() if snippets are disabled Jul 14, 2021
@ccordoba12 ccordoba12 merged commit 1d7091b into develop Jul 14, 2021
@ccordoba12 ccordoba12 deleted the krassowski-hotfix-1 branch July 14, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants