Fix pylint test without pylsp installed #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @jspricke, thanks for your contribution. Could you explain why is this neccesary? I mean, how are you testing this package? |
|
Hi @ccordoba12, this is necessary to have the test pass in Debian: https://buildd.debian.org/status/fetch.php?pkg=python-lsp-server&arch=all&ver=1.2.2-2&stamp=1632064450&raw=0 where we run the tests after the build and before installing the app. |
In case pylsp is not installed, the pylint plugin is not found in Config.__init__ and Config._plugin_settings is empty. This is fine except test_pylint_lint.test_pylint tries to set the pylint executable in the settings. This patch works around this by patching in the config.
jspricke
force-pushed
the
fix_pylint
branch
from
b344c0c to
3ab65c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case pylsp is not installed, the pylint plugin is not found in
Config.init and Config._plugin_settings is empty. This is
fine except test_pylint_lint.test_pylint tries to set the pylint
executable in the settings. This patch works around this by patching in
the config.