Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional meta data to schema and errors #120

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

danielbradburn
Copy link
Contributor

This pull request adds additional information in the schema object (name and dered) and additional stores a reference in schema errors to the schema that caused the error. This gives us the ability to provide additional context when an error occurs, for example if the schema is named then the name of the schema, or if the yaml is parsed with ruamel.yaml we can show the line and column number that generated the error.

…store schema in errors. This gives us the ability to provide additional context when an error occurs, for example if the schema is named then the name of the schema, or if the yaml is parsed with ruamel.yaml we can show the line and column number that generated the error.
@codecov
Copy link

codecov bot commented Mar 8, 2019

Codecov Report

Merging #120 into master will increase coverage by 1.61%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #120      +/-   ##
=========================================
+ Coverage   96.19%   97.8%   +1.61%     
=========================================
  Files          54      54              
  Lines        1444    1457      +13     
=========================================
+ Hits         1389    1425      +36     
+ Misses         55      32      -23
Impacted Files Coverage Δ
openapi_core/schema/schemas/generators.py 100% <100%> (ø) ⬆️
openapi_core/schema/schemas/models.py 98.72% <100%> (+4.49%) ⬆️
openapi_core/schema/schemas/registries.py 100% <100%> (ø) ⬆️
openapi_core/schema/schemas/exceptions.py 100% <100%> (+17.3%) ⬆️
openapi_core/schema/schemas/factories.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 395f68b...9969e6c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant