Create oneOf/anyOf unmarshaller using unmarshallers factory #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov Report
@@ Coverage Diff @@
## master #425 +/- ##
=======================================
Coverage 92.84% 92.84%
=======================================
Files 94 94
Lines 2347 2348 +1
Branches 297 297
=======================================
+ Hits 2179 2180 +1
Misses 128 128
Partials 40 40
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've refactored the way how unmarshallers for
oneOf/anyOfsub-schemas are created by using theSchemaUnmarshallersFactoryinstead of instantiating anObjectUnmarshallermanually.I believe this is what you were hinting at in https://github.com/p1c2u/openapi-core/pull/354/files#r979402096.