Bump versions, drop support for Python 3.8 #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-k
reviewed
Oct 22, 2024
pyproject.toml
Outdated
| jsonschema = "^4.19.1" | ||
| rfc3339-validator = "*" # requred by jsonschema for date-time checker | ||
| jsonschema-specifications = ">=2023.5.2" | ||
| jsonschema-specifications = "^2024.10.1" |
There was a problem hiding this comment.
What's the point of ^ when using calendar versioning? Releases in January of 2025 aren't more likely to include breaking changes than those in December of 2024.
There was a problem hiding this comment.
You are right, I replaced it with >=
…likely to include breaking changes than those in December of 2024 therefore stick to >=
even-even
reviewed
Nov 29, 2024
.github/workflows/python-test.yml
Outdated
| @@ -14,7 +14,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| python-version: ['3.8', '3.9', '3.10', '3.11'] | |||
| python-version: ['3.9', '3.10', '3.11', '3.12'] | |||
There was a problem hiding this comment.
I suggest adding support python 3.13 in this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Python 3.8 is end of life and I added support for Python 3.12. More importantly I upgraded jsonschema-specifications :)
Also added support for Python 3.13
I hope this is alright.