Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include tests in sdist archives #199

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Mar 11, 2023

Include the "tests" directory in sdist archives, to permit Linux distributions to use these archives instead of GitHub snapshots that are not reliable long-term.

Include the "tests" directory in sdist archives, to permit Linux
distributions to use these archives instead of GitHub snapshots that are
not reliable long-term.
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #199 (fb1bb55) into master (91f5cf2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #199   +/-   ##
=======================================
  Coverage   92.60%   92.60%           
=======================================
  Files          13       13           
  Lines         433      433           
  Branches       64       64           
=======================================
  Hits          401      401           
  Misses         22       22           
  Partials       10       10           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@p1c2u
Copy link
Collaborator

p1c2u commented Mar 16, 2023

@mgorny that's a good idea, thanks for the contribution

@p1c2u p1c2u merged commit dc30e7b into python-openapi:master Mar 16, 2023
@mgorny mgorny deleted the test-sdist branch March 16, 2023 15:39
@mgorny
Copy link
Contributor Author

mgorny commented Mar 16, 2023

Thank you! Should I open PRs for other openapi repositories or can you handle it from here?

@p1c2u
Copy link
Collaborator

p1c2u commented Mar 17, 2023

@mgorny if that's the only change needs to be done to make it work then I can handle this

@mgorny
Copy link
Contributor Author

mgorny commented Mar 17, 2023

@mgorny if that's the only change needs to be done to make it work then I can handle this

I think so, unless tests require extra files to run. In any case, I'll test them on the next release and submit a PR if anything else is needed. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants