-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use IUPAC tables for atomic weight and isotopic abundance #58
Conversation
Be, Mg and Ta have been updated since the X-ray tables were last checked, and the file formats changed slightly. The readme for the download file does not indicate that they have changed. |
There is a neutron cross section table in Dawidowski (2013) [DOI:10.1016/B978-0-12-398374-9.09989-7]. The paper indicates that some values have been updated from Sears (1992), but they don't list which ones or cite sources for the changes. I haven't found anything more recent. |
Skipping Dawidowski table. See comments in #59 |
Master already has changes to mass table. This just completes the work, so merging. There is a R1.7 branch with changes prior to the mass updates that will be released before the 2.0 with the new masses. |
Since we are updating masses of isotopes we should also be updating the other parts of the mass calculation.
I suggest using the source here: https://www.ciaaw.org/isotopic-abundances.htm
This is not yet complete because the sld estimate is based on abundance, so tests are still breaking, but I'm showing the work in progress to gather comments. In particular, this will change SLD values by a small amount so test cases in other projects which use the values from the calculator may break on this release.
I suppose that means we should release this as 2.0, which also means we should update the xray and neutron tables to the newest values.
Refs #41