MAINT: fixes for numpy 2 #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, sorry - my most recent PR is a dupe of this. Closing mine... |
|
Any chance of pushing this change out as a quick bugfix release, before the larger release in the wings? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numpy version 2, which is in release candidate stage, has removed
np.NaNas an alias tonp.nan. Onlynp.nanis usable with numpy==2.This PR removes the usage of
np.NaNin the package. These issues were picked up during testing of a third party package, there may be other issues lurking for numpy 2 compatibility.Would it be possible to release a new version to PyPI when/if this PR is merged?