I wirte some simple demos, please merge it #40
Conversation
|
The first thing I've tested is the histogram. |
|
Doh! I would love to get these in somehow at somepoint… |
|
I do some small changes and all demos pass test on Ubuntu 12.04 64bit, I have never see people use Python 3 in production, |
|
I think demo code should have more comments explaining what things are doing, and the README.md should explain what each program is demonstrating. Also, I think "pixsel" is a typo for "pixel". |
|
@shuge The master branch now supports Python 3… |
|
Thanks. File name and fodler name have self-explain what each program is demonstrating. I have used range instead of xrange. |
|
Thanks, can you fix "This pull request cannot be automatically merged." ? I don't know if there are other objections but I'd prefer to merge through the web if possible. |
|
shuge, I appreciate your taking the time to write these demos, and I want to emphasize that this is only my point of view; I can't speak for the Pillow maintainers here. But your English is not very good and I don't think the filenames are self-explanatory enough; tutorial code needs to have more documentation. In addition, I have concerns about the coding style. Some of the demo files do draw_text.py will throw an Exception with no message on any platform other than "darwin" or "win32", so I don't believe you when you say these demos pass on Ubuntu. |
| BLACK = "#ffffff" | ||
| WHITE = "#000000" | ||
|
|
||
| fg_color = WHITE |
There was a problem hiding this comment.
This variable is never used. Why does it exist?
|
You should probably also have done a rebase so that the lena image isn't first checked in and then removed. |
|
+1 to rebase |
Sorry, I don't know how to fix it |
Conflicts: .gitignore
of C code that doesn't compile with Python 3.
Plus, TGA was eligible for a round-trip test in test_imagefile. It has one now.
The EPS encoder wasn't part of Gohlke's test suite, so the previous "fixes" there were only expected syntactic ones. This gives a cleaner fix to the encoder. The decoder doesn't work in round-trip due to a missing eps_decoder method on the core module, but it's clear it worked at some point.
For some reason, the PCX codec round-trips now.
After adding all the encode() calls, the PDF plugin (and a few others) became much harder to read. This should be much easier on the eyes.
Not too convinced of the size fix. While it works against my file, I'm not sure someone would have accidentally been an index off and not noticed.
This test includes an XPM file with transparency.
This is unnecessary now.
This fixes a build warning on 64-bit machines.
...although, you have to turn on deprecation warnings specifically in order to get them.
…hon 2.5 is no longer supported (its support is broken in many ways in this branch); remove bundled doctest.py module (it is in stdlib since forever); remove extra stuff from tox.ini
String exceptions don't work anymore.
The Sane documentation seems to imply that these option strings contain Latin-1 text, not byte data, so we decode it and present it to the user that way.
Conflicts: .gitignore
|
There is still some work which need to be done before this is main-repo-ready. histogram.py e.g. still contains .draft(), pixsel, xrange() |
|
Sorry, I don't know what's going on with this, but I'm going to close it until after Pillow 2.0 is released. I want lena demos, but I don't want to merge controversial code. 🎱 |
Updated freetype to 2.6.5
I wirte some simple demos, please merge it.