Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Enable ImageGrab grab for Linux #4198

Closed
wants to merge 5 commits into from

Conversation

vkresch
Copy link

@vkresch vkresch commented Nov 6, 2019

Changes proposed in this pull request:

  • Enable to use ImageGrab.py not only on mac and windows but on linux too
  • Depends on ImageMagick sudo apt-get install imagemagick

Please point me to the parts which also needs to be change like the installation script.

@nulano
Copy link
Contributor

nulano commented Nov 6, 2019

Note that I have a WIP patch using the XCB library, which I believe is more common, but I doubt I will be able to work on it until mid-December. As the next release is on 1 January, I'd suggest waiting until later before merging this.

@radarhere
Copy link
Member

Just to link, see #2028 for a discussion of this.

@vkresch vkresch changed the title Enable ImageGrab for linux WIP: Enable ImageGrab for linux Nov 11, 2019
@radarhere radarhere changed the title WIP: Enable ImageGrab for linux WIP: Enable ImageGrab grab for linux Nov 30, 2019
@radarhere
Copy link
Member

Just to note - this doesn't add support for all of ImageGrab on Linux, only the grab method - if this were to progress, you might want to throw an error on grabclipboard.

@radarhere radarhere changed the title WIP: Enable ImageGrab grab for linux WIP: Enable ImageGrab grab for Linux Dec 28, 2019
@python-pillow python-pillow deleted a comment from codecov bot Feb 23, 2020
@python-pillow python-pillow deleted a comment from codecov bot Mar 9, 2020
@radarhere
Copy link
Member

@vkresch #4260 has been merged. Do you feel there is value in including your functionality as well, or are you happy for this to be closed?

@vkresch
Copy link
Author

vkresch commented Apr 4, 2020

@radarhere thanks it can be closed.

@vkresch vkresch closed this Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants