-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove excess Travis CI jobs #5029
Conversation
I can see two changes on Codecov:
An unrelated change is in |
Thanks, fixed setting the |
PyQt now added to GHA, like Travis had, so some skipped PyQt tests are now ran:
I didn't find a way to add XCB, although adding Qt changed this skip:
into:
The coverage drops in this PR compared to src/display.cXCB stuff: Tests/test_imagegrab.pyXCB stuff, this is:
Tests/test_image_quantize.pyIf I'm interpreting correctly, we're not skipping this test, so coverage dropped! Will add a Edit: done. |
I'd like to get this merged soon so we can right away start conserving Travis credits. I've already used a third of my allowance in two days! I'm not sure how to get the XCB stuff into GHA (or AppVeyor). Do we want to:
|
I've just created hugovk#62 to resolve the XCB coverage. |
Set XVFB bit depth
Great timing, thank you! |
For #5028.
Changes proposed in this pull request:
TODO
Check coverage drops and see what's tested on Travis that's not in GHA
There's some redundant bits of scripts that can be removed now or later, e.g.
TRAVIS_PYTHON_VERSION
checks