Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add light mode bg to 3rd and 4th level menu items #5056

Merged
merged 4 commits into from
Dec 21, 2020

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Nov 24, 2020

Fixes #5053.

Changes proposed in this pull request:

  • Don't add a light mode background colour to fourth-level menu items
  • Let them inherit styles instead
  • Fixes unreadable menu items in dark mode

Example

https://pillow--5056.org.readthedocs.build/en/5056/reference/ImageFont.html#functions

Dark mode

image

Light mode

image

@nulano
Copy link
Contributor

nulano commented Nov 24, 2020

This does fix the readability issue, but the menu looks less uniform without the extra background highlight. Trying the opposite color manually #363636 looks good, although I don't see an obvious way to add it based on the dark/light selection. If that is too complicated then this is obviously worth removing at least for now.

@hugovk
Copy link
Member Author

hugovk commented Nov 24, 2020

How's this with CSS? For some reason the RTD PR build hasn't updated dark.css or included light.css in the docs, even though light.css is now on the server.

Anyway, it looks like this locally:

| image| image|

@nulano
Copy link
Contributor

nulano commented Nov 24, 2020

The screenshots look good.

It's hard to test with the RtD build not updated, but I think this might break Internet Explorer compatibility (since it doesn't support the @media tag). However, I don't think it's worth worrying about a minor style inconsistency on an unsupported browser, so probably fine.

Fix 3rd level menu item background-color in dark mode
@hugovk hugovk changed the title Don't add light mode bg to 4th level menu items Don't add light mode bg to 3rd and 4th level menu items Dec 21, 2020
@radarhere radarhere merged commit 0e50e72 into python-pillow:master Dec 21, 2020
@hugovk hugovk deleted the fix-4th-level-menu-dark-mode branch December 21, 2020 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: 4th level menu items not showing in dark mode
3 participants