-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move code from pillow-wheels #7418
Conversation
Updated openjpeg to 2.5.0, except on macOS x86_64
Updated openjpeg to 2.5.0 on macOS x86_64
Deploy to GitHub Releases when a tag is set
Updated harfbuzz to 4.3.0
Added manylinux_2_28
Added Python 3.11.0b3
Updated harfbuzz to 4.4.0
Updated auditwheel to include auditwheel#376
Removed symlink as Pillow now checks /usr/local/lib/libfribidi.dylib
Updated harfbuzz to 4.4.1
Updated libtiff to 4.4.0
updates: - [github.com/pre-commit/pre-commit-hooks: 8fe62d14e0b4d7d845a7022c5c2c3ae41bdd3f26 → 3298ddab3c13dd77d6ce1fc0baf97691430d84b0](pre-commit/pre-commit-hooks@8fe62d1...3298dda)
…-update-config
Updated libwebp to 1.2.3
Ok, done. |
Not entirely sure why, but I'm excited about the pillow-wheels code moving here (rollin' rollin' rollin') thanks @radarhere @hugovk |
I'm currently most concerned about not being able to run Travis CI except during releases. I don't want us to find out on release day something has broken. Can we try these workarounds and/or split Travis CI into its own PR? |
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Ok, I've pushed a commit. TravisCI will run every time, but will exit early if the conditions are not met. |
Thanks! Hmm, now I'm wondering if (lots of builds) x (exiting early) will nevertheless eat up our credits... However, it looks like non-admins like us can restart builds and jobs (e.g. at https://app.travis-ci.com/github/python-pillow/Pillow/builds/266245399), and also trigger new builds, which is good. @aclark4life The credits page that is only visible by admins. Please can you paste some screenshots of the current credits usage? |
If tags and manual builds are too infrequent, Or we could restrict Travis to tags and manual builds, and use python-pillow/pillow-wheels#367 for a cron? |
At first I thought only admins could do manual builds, and thought that we'd only get builds for tags during release, which would be too infrequent. But happily I was wrong about that. What we need is to build from tags for releases. That's fine. Plus to be able to do some builds in between releases to prevent surprises. Manual builds is okay for that. Plus, what I think is missing is to be able to see the results of PR changing the Travis related files. I guess we'll just have to hope for the best, merge, then do a manual build and iterate as needed? |
51dd0fc
to
c20801c
Compare
for more information, see https://pre-commit.ci
Ok, I've removed the commit to run Travis every time.
If there was concern, which I expect there isn't most of the time, we could push the PR as a branch to Pillow, and then trigger a Travis build of that Pillow branch. |
Yes, good idea! Thanks! |
Two changes for the pillow project. 1. Pillow previously had a separate repository for wheel building scripts - https://github.com/python-pillow/pillow-wheels However, that has been incorporated into the main repository for simplicity - python-pillow/Pillow#7418 So this PR updates the project here to use the new location. 2. Pillow's oss-fuzz CI job is [currently failing because pip is too old](https://github.com/python-pillow/Pillow/actions/runs/6666944851/job/18119459590#step:4:9947). So this PR updates it. cc @hugovk --------- Co-authored-by: Andrew Murray <radarhere@users.noreply.github.com>
Previously, when we've done point releases, dependency updates merged into pillow-wheels were automatically incorporated into the newly released wheels. With this change though, that will no longer be the case, so we may want to take a moment when creating point releases to consider whether any dependency updates are important and should be cherry-picked in. |
Yes, good idea, let's keep it in mind when planning point releases. |
Helps #7390
As suggested in that issue, moves the https://github.com/python-pillow/pillow-wheels code into this main repository, in order to simplify the release process.
I have setup the new "Wheels" job to be triggered on
Regarding TravisCI