Optimise ImageMode.getmode
using functools.lru_cache
#7641
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
functools.lru_cache
instead of our own global cache, to only cache those which are requested.With no argument,
lru_cache
defaults tomaxsize=128
, plenty for the 33 valid inputs.https://docs.python.org/3/library/functools.html#functools.lru_cache
Performance improves for all the following cases.
A mode from the top half: 33.6 -> 28.5 nsec
Before and after:
A mapping mode from the bottom half: 36 -> 28.9 nsec
All modes: 1.25 -> 1.01 usec