-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
winbuild: Refactor dependency versions into constants #7843
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Two suggestions:
- Do we also want
V['libimagequant']
for consistency? - I would also include
SF_PROJECTS
in the format strings now that it's not the only variable. IIRC it was done with a plus operator because it was the same length, but now it saves one character :).
Co-authored-by: Ondrej Baranovič <ondreko.tiba@gmail.com>
Yes, but let's do it when we're no longer pointing to a Git hash: Pillow/winbuild/build_prepare.py Lines 324 to 344 in 1b7bcfb
Good idea, suggestions applied! |
I've added a couple more commits to silence IDE (PyCharm) squiggly warnings. |
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
Changes proposed in this pull request:
__main__
calls intomain()
to avoid shadowing variablesSee also the last commit, I first put them as separate constants like:
I then refactored that into a single dict:
So we can refer to them like
V['BROTLI']
instead ofBROTLI_VERSION
, but I'm not sure which I prefer.Thoughts?
cc @nulano