Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TIFF tag OSUBFILETYPE when saving using libtiff #7893

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

radarhere
Copy link
Member

Resolves #7892

The issue has found a TIFF image with tag 255, OSUBFILETYPE, that fails to save using libtiff.

It is described at https://www.awaresystems.be/imaging/tiff/tifftags/subfiletype.html as 'deprecated', and TiffTags.py says that we don't support it.

LIBTIFF_CORE.remove(255) # We don't have support for subfiletypes

So this PR simply removes it when saving using libtiff.

@radarhere radarhere added the TIFF label Mar 22, 2024
@radarhere radarhere changed the title Block saving TIFF tag OSUBFILETYPE using libtiff Remove TIFF tag OSUBFILETYPE when saving using libtiff Mar 22, 2024
@eroux
Copy link

eroux commented Mar 22, 2024

this is great, thanks a lot!!

@hugovk hugovk merged commit 0c73db3 into python-pillow:main Mar 22, 2024
57 checks passed
@radarhere radarhere deleted the osubfiletype branch March 22, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saving binary tiff files with tiff_deflate compression fails under certain conditions
3 participants