-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Actions: use macos-13
or macos-14
instead of macos-latest
#8010
Conversation
GitHub has now added Python 3.8 and 3.9 to actions/setup-python#808 (comment) We can save about 45s of CI time if we switch them all to
https://github.com/python-pillow/Pillow/actions/runs/8840522550/usage
https://github.com/hugovk/Pillow/actions/runs/8843777263/usage Which is a nice little saving, but not huge in the scale of our CI. The question is, shall we keep testing at least one job on Might help find some bugs. |
Python 3.9.1 was the first version of Python to support Silicon, but it looks like it was only backported to Python 3.8 in 3.8.10. It's not really a strong argument, but that makes me think we should keep |
Sure, although we'll still have Intel users for a while longer. The internet speculates Apple might support Intel until 2025 or 2026 or 2027, and that we'd have to wait to see what Apple actually decides because they've not announced anything. |
Regarding when users will actually stop using Intel, it's worth remembering that last month we received an issue about macOS 10.10, which is almost 10 years old at this point. |
Indeed, and we don't have to support such old versions. Anyway, I suggest we leave 3.8 and 3.9 on Intel for now. |
Also depends on user demand. If you take away something and people notice it's gone, then we can always put it back. In general, I would drag along as broad a support as you can easily maintain. As the maintenance burden increases for older tech, you can base the decision to drop it on predicted user demand and act accordingly. If you need to support something you can't easily support, then it gets harder. 🤔 |
Yeah, it all adds up. I think a fair amount of effort has gone into maintaining old macOS versions, all of which is time away from everything else. Having clear policies helps both our users and us. We have:
Which means macOS 12, 13 and 14, not 10.10, 10.11, 10.12, 10.13, 10.14, 10.15 or 11 - 10.10 is very much no longer receiving security updates. For the time-being, I don't mind keeping 10.10 along. |
GitHub is migrating
macos-latest
to point tomacos-14
which is (a) M1 and (b) does not have Python 3.8 or 3.9:This can cause failed builds for migrated repos.
At least during this migration, let's explicitly use
macos-13
ormacos-14
instead ofmacos-latest
.