Added argument to raise warnings from factory errors on UnidentifiedImageError #8033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yay295
reviewed
Apr 30, 2024
Comment on lines
+122
to
+124
| with pytest.warns(UserWarning): | ||
| with pytest.raises(UnidentifiedImageError): | ||
| with Image.open(im, warn_possible_formats=True): |
There was a problem hiding this comment.
I think these can all be in the same with statement, separated by commas. Though that might make the line too long.
There was a problem hiding this comment.
If I do that, and then run black, I get
with pytest.warns(UserWarning), pytest.raises(
UnidentifiedImageError
), Image.open(im, warn_possible_formats=True):This does not look clearer to me.
nulano
reviewed
Apr 30, 2024
Comment on lines
3347
to
+3351
| # Leave disabled by default, spams the logs with image | ||
| # opening failures that are entirely expected. | ||
| # logger.debug("", exc_info=True) | ||
| if warn_possible_formats: | ||
| warning_messages.append(i + " opening failed. " + str(e)) |
There was a problem hiding this comment.
Suggested change
| # Leave disabled by default, spams the logs with image | |
| # opening failures that are entirely expected. | |
| # logger.debug("", exc_info=True) | |
| if warn_possible_formats: | |
| warning_messages.append(i + " opening failed. " + str(e)) | |
| if warn_possible_formats: | |
| warning_messages.append(i + " opening failed. " + str(e)) |
The comment is probably no longer relevant with this change.
|
Closing due to #7993 (comment). See the issue for further discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7993
If a user tries to open the image from that issue
they will see
If the user would like to investigate further, this PR adds "warn_possible_formats". It will show any errors raised during the checking of the formats as warnings.
giving