Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ImageDraw.getdraw hints parameter #8124

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

radarhere
Copy link
Member

ImageDraw.getdraw() has a hints argument. Its purpose is to indicate whether or not _imagingagg should be used instead of ImageDraw2.

However, _imagingagg doesn't exist, so I suggest deprecating the hints argument.

@radarhere radarhere added the Deprecation Feature that will be removed in the future label Jun 10, 2024
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be related to Fredrik Lundh's aggdraw project: "An add-on to the PIL library that supports anti-aliased drawing".

However, I don't find any reference to _imagingagg in the 2005 source download at https://web.archive.org/web/20200220003311/http://www.effbot.org/downloads/#aggdraw or in any of the code or commits of the fork at https://github.com/pytroll/aggdraw.

docs/releasenotes/10.4.0.rst Outdated Show resolved Hide resolved
docs/deprecations.rst Outdated Show resolved Hide resolved
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
src/PIL/ImageDraw.py Outdated Show resolved Hide resolved
@hugovk
Copy link
Member

hugovk commented Jun 10, 2024

The 3.13 failures are unrelated: actions/setup-python#886

We can work around by pinning to "3.13.0-beta.1", but those builds just came out so let's give GitHub Actions a bit of time to fix.

@radarhere
Copy link
Member Author

3.13 is back to passing now.

@radarhere radarhere changed the title Deprecate ImageDraw.getdraw hints argument Deprecate ImageDraw.getdraw hints parameter Jun 10, 2024
@hugovk hugovk merged commit 7928beb into python-pillow:main Jun 11, 2024
56 checks passed
@radarhere radarhere deleted the imagedraw_getdraw branch June 11, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecation Feature that will be removed in the future
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants