Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate JpegImageFile huffman_ac and huffman_dc #8274

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Deprecate JpegImageFile huffman_ac and huffman_dc #8274

merged 2 commits into from
Aug 1, 2024

Conversation

radarhere
Copy link
Member

These dictionaries have been unused since PIL, so let's deprecate them.

Pillow/src/PIL/JpegImagePlugin.py

Lines 349 to 350 in 4df4df2

self.huffman_dc: dict[Any, Any] = {}
self.huffman_ac: dict[Any, Any] = {}

@radarhere radarhere added the Deprecation Feature that will be removed in the future label Aug 1, 2024
@hugovk
Copy link
Member

hugovk commented Aug 1, 2024

And mention something like "and will be removed in Pillow 12 (2025-10-15)" in deprecations.rst and 11.0.0.rst?

@hugovk hugovk added the automerge Automatically merge PRs that are ready label Aug 1, 2024
@radarhere radarhere merged commit 95cc0b1 into python-pillow:main Aug 1, 2024
50 checks passed
@radarhere radarhere deleted the unused_jpeg branch August 1, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

Assignees
No one assigned
Labels
automerge Automatically merge PRs that are ready Deprecation Feature that will be removed in the future
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radarhere @hugovk