Added logging to TiffImagePlugin fixIFD() #8568
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #8316
For this TiffImagePlugin
fixIFD()
codePillow/src/PIL/TiffImagePlugin.py
Lines 2205 to 2211 in 4304414
the original PR suggests catching
RunTimeError
s ("not implemented", "wrote only {bytes_written} bytes but wanted {expected}" or "offset is not supported") and re-raising it with tag info appended to the error message.I think the way this is done in the rest of TiffImagePlugin is to use
logger.debug()
.Pillow/src/PIL/TiffImagePlugin.py
Lines 982 to 988 in 4304414
So this PR uses
logger.debug()
instead.