Keep new IFDs when converting EXIF to bytes #8635
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8634
The following code doesn't currently keep the new IFD tag when converting to bytes.
This is because the new IFD is added to
exif._ifds
, but notexif._data
. It makes sense to not save it toexif._data
, because a tag value for the IFD would indicate the IFD offset, which only has meaning in byte format. However,exif._ifds
isn't checked when converting to bytes, so the new IFD is forgotten.This PR fixes that.