Always update rust when building libavif on Windows#8855
Closed
radarhere wants to merge 1 commit intopython-pillow:mainfrom
Closed
Always update rust when building libavif on Windows#8855radarhere wants to merge 1 commit intopython-pillow:mainfrom
radarhere wants to merge 1 commit intopython-pillow:mainfrom
Conversation
Member
|
Thanks! Good to know we can restart it and hopefully get the newer runner. I'll go ahead with the release without merging it to save a bunch of CI time, but we can merge it afterwards if we see it pop up again. |
Member
|
Does this mean that we have rust available across all the platforms now? |
Member
Author
|
Not quite. Cygwin and the Docker images don't have rust, but they also don't have libavif support at the moment. I don't think MinGW has rust, but I might just be missing some MinGW nuance. |
Contributor
MSYS2 distribution of MinGW has: https://packages.msys2.org/base/mingw-w64-rust Also, libavif and rav1e are usually up to date there, one would rarely need to build them (static libs also included). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently in the libavif PR, an error occurred when building rav1e in Windows wheels. I reported it at AOMediaCodec/libavif#2703, and the suggestion was to install a Rust toolchain - fdintino#32
I opted for a simpler fix,
rustup update- fdintino#33I noticed the same problem happening in the non-wheels Windows jobs, but a new runner image fixed the problem.
#8851 (comment) has now reported a problem building rav1e in the Windows jobs. Those jobs have, for some reason, decided to suddenly use a runner image two weeks old.
Running the jobs again allows them to pass, but I offer this PR as a more proactive measure if you would like one - running
rustup updatein all the Windows builds.